Overview
| Comment: | iOS: Get the length from the generator
This fixes reading over the buffer if it is not zero terminated. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
af661fbcc54e9f67445b5d4a95457b14 |
| User & Date: | js on 2017-10-21 20:04:45 |
| Other Links: | manifest | tags |
Context
|
2017-10-21
| ||
| 20:07 | iOS: Allow all orientations check-in: 1a36714841 user: js tags: trunk | |
| 20:04 | iOS: Get the length from the generator check-in: af661fbcc5 user: js tags: trunk | |
| 18:45 | Add iPad icon check-in: d444c9ace7 user: js tags: trunk | |
Changes
Modified iOS/ShowDetailsController.m from [2d0d3612cd] to [728614f00a].
| ︙ | ︙ | |||
196 197 198 199 200 201 202 |
@try {
[generator derivePassword];
} @finally {
of_explicit_memset(passphrase, 0, strlen(passphrase));
free(passphrase);
}
| | | > > | < | 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 |
@try {
[generator derivePassword];
} @finally {
of_explicit_memset(passphrase, 0, strlen(passphrase));
free(passphrase);
}
NSMutableString *password = [[[NSMutableString alloc]
initWithBytes: (char *)generator.output
length: generator.length
encoding: NSUTF8StringEncoding] autorelease];
of_explicit_memset(generator.output, 0, generator.length);
dispatch_sync(dispatch_get_main_queue(), ^ {
activityController.view.hidden = YES;
block(password);
});
});
}
|
| ︙ | ︙ |