ObjXMPP  Check-in [ad2e692fe7]

Overview
Comment:XMPPConnection: Don't negotiate a session feature, when marked optional

The session feature has been deprecated as of RFC 6120.
Some servers still offer it for client compatibility, but
mark it as optional. Not negotiating it in this case
saves us a round trip

Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: ad2e692fe74ca51122abbf103726b2f1324e506c4642b2f6cc4f52081d7ee2e3
User & Date: florob@babelmonkeys.de on 2014-02-03 23:00:09
Other Links: manifest | tags
Context
2014-06-18
11:24
Update buildsys check-in: f43f54ba69 user: js tags: trunk
2014-02-03
23:00
XMPPConnection: Don't negotiate a session feature, when marked optional check-in: ad2e692fe7 user: florob@babelmonkeys.de tags: trunk
22:50
XMPPRoster: Ensure roster pushes were sent by the server check-in: 6f1b17c116 user: florob@babelmonkeys.de tags: trunk
Changes

Modified src/XMPPConnection.m from [15582e8207] to [24f700eb94].

1098
1099
1100
1101
1102
1103
1104
1105

1106
1107
1108
1109
1110
1111
1112
			[self XMPP_sendAuth: @"PLAIN"];
			return;
		}

		assert(0);
	}

	if (session != nil)

		_needsSession = true;

	if (bind != nil) {
		[self XMPP_sendResourceBind];
		return;
	}








|
>







1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
			[self XMPP_sendAuth: @"PLAIN"];
			return;
		}

		assert(0);
	}

	if (session != nil && ![session elementForName: @"optional"
					     namespace: XMPP_NS_SESSION])
		_needsSession = true;

	if (bind != nil) {
		[self XMPP_sendResourceBind];
		return;
	}